Looking to hire developers?
Please provide any and all feedback.
Thank you! b
@NaveenGumaste
Posted
Hello Roque Rodriguez ! Congo 👏 on completing this challenge
Let's look at some of your issues, shall we:
<body>
<main class="container">
*all you content here*
</main>
</body>
see if you use <ul> and <ol> should have <li> as there child. no other tag will work
happy Coding😀
@shashreesamuel
Posted
Hey SourceCodeDad, good job on completing this challenge. Keep up the good work.
Your solution looks good however I think you should consider the following
your card needs to be in the center. You can use margin: 0 auto to center the card in the middle of the page.
The margin-top above the text is too high as compared to the design. You can alter this using the css property margin-top
The font weight of the title text is supposed to heavier
The font weight of the number part of the card statistics should be in a heavier font weight. This can be altered using font-weight.
The card should have some padding around using the padding css property.
In terms of your accessibility issues
<ul> and <ol> must only directly contain <li>, script or <template> elements. It seems like you have an empty <ul> tag where the child elements are outside.
wrap all your content within <main> tags to fix the rest of your accessibility issues.
In terms of your html validation errors
the element <div> is not allowed as a child of the element <ul>.
I hope this helps
Cheers Happy coding 👍
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
