Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Stats product challenge (HTML and CSS)

Lucas•70
@lu0tero
A solution to the Stats preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


All feedback is welcome!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Lucas 👾•104,160
    @correlucas
    Posted almost 3 years ago

    👾Hola Lucas, congratulations for your solution!

    I saw that you did pretty much anything, the container is working fine, its flexible and responsive. But there's some work to do around the container design and semantics.

    1.Use semantic tags to wrap the content, for example using section for each column and main for the general container.

    2.Do the import for the image using picture or img.

    3.Give it the properly overlay effect, you've used filter but is hard to get the same color with this effect, instead use mix-blend-mode: multiply; inside the img tag (note that in this case you have to import the image inside the html with <img>).

    Hope it helps and happy coding!

    Marked as helpful
  • Luan•200
    @LuanFlorencioo
    Posted almost 3 years ago

    Hola Lucas, acabo de enviar una solicitud de extracción allí en tu repositorio de github para que puedas ver la mejora que hice en tu código. Espero poder ayudarte.

    Mejoré algunas líneas de código e implementé la funcionalidad para dispositivos móviles y tabletas.

    Marked as helpful
  • romila•3,550
    @romila2003
    Posted almost 3 years ago

    Hi Lucas,

    Congratulations 🎉 on your second challenge. It was a good attempt, particularly in the desktop version.

    When looking at your design and code, I noticed the lack of responsiveness of your card when adjusting the screen sizes. Approximately at 1100px and onwards, your card looks great however when the screen size is less than that, the card does not respond properly. At 375px, it also looks good though due to the use of media queries. Thus, a good approach for your problem would be to use a mobile-first approach instead. There are many resources explaining the benefits of this approach however the main reason is because it is easier to adjust the layout as you increase the screen size. If you do not understand this concept properly, you can always research more about this through YouTube or other sources like websites or articles. So instead of using @media screen and (max-width: 375px) { }, you should use the @media screen and (min-width: xx px instead). The xx indicates the screen size you can use when increasing the screen size e.g. @media screen and (min-width: 700px).

    Also, it is good practice to use the main tag to wrap your content as it is semantically correct e.g. <main class="container"></main>.

    Hope these comments and suggestions provide some use. I wish you all the best in your future projects 👍.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub