Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Status Preview Card Component Main

@aelhamrawy

Desktop design screenshot for the Stats preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Glad and ,Highly appreciated any feedback or advice

Community feedback

@pikapikamart

Posted

Hey, great work on this one. Desktop layout seems great but your breakpoint is too late, right now, before the breakpoint the layout is too squished and occupies the whole screen which is not great to look at, making the breakpoint sooner would be great. Mobile layout seems great as well.

Some other suggestions would be:

  • Do not use height: 100% on the body or html as they are relative to the viewport. Use min-height: 100vh so that they won't have a fixed height and let the element expand if needed.
  • Your .summary could have used ul since those are "list" of information about the company website. -Also, inside in those list information, those text should not be using a heading tag because they don't really give content on what the section would contain right, so better using p tag on them.
  • When wrapping a text-content do not just use span to wrap it, use meaningful element like a p tag if it just a regular text or heading tag if it is an heading.
  • Do not directly type the wordings as uppercase on the markup, if you do this, screen-reader will read the text letter-by-letter and not by the wordings. Use only the lowercase version to write in the markup and instead use text-transform: uppercase on it.
  • Lastly, maybe making the site's responsiveness better.

Aside from those, great job again on this one.

Marked as helpful

2

@aelhamrawy

Posted

Hey @pikamart

Thank you very much for your time reviewing my app, and appreciated sharing your knowledge with me.

I modified the solution as per the points mentioned in your comment.

Best Regards

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord