@pikapikamart
Posted
Hey, great work on this one. Desktop layout seems great but your breakpoint is too late, right now, before the breakpoint the layout is too squished and occupies the whole screen which is not great to look at, making the breakpoint sooner would be great. Mobile layout seems great as well.
Some other suggestions would be:
- Do not use
height: 100%
on thebody
orhtml
as they are relative to the viewport. Usemin-height: 100vh
so that they won't have a fixedheight
and let the element expand if needed. - Your
.summary
could have usedul
since those are "list" of information about the company website. -Also, inside in those list information, those text should not be using a heading tag because they don't really give content on what the section would contain right, so better usingp
tag on them. - When wrapping a text-content do not just use
span
to wrap it, use meaningful element like ap
tag if it just a regular text or heading tag if it is an heading. - Do not directly type the wordings as uppercase on the markup, if you do this, screen-reader will read the text letter-by-letter and not by the wordings. Use only the lowercase version to write in the markup and instead use
text-transform: uppercase
on it. - Lastly, maybe making the site's responsiveness better.
Aside from those, great job again on this one.
Marked as helpful
@aelhamrawy
Posted
Hey @pikamart
Thank you very much for your time reviewing my app, and appreciated sharing your knowledge with me.
I modified the solution as per the points mentioned in your comment.
Best Regards