@thetechacks
Posted
Hey there it looks amazing !!
I just noticed that in the mobile view when the hamburger is clicked a green color outline is formed and if the links in the mobile menu are clicked the underline in the link looks odd...
I even noticed that when the menu is active the background is not a linear-gradient.
Just that, though overall it's amazing :)
@pikapikamart
Posted
@thetechacks Hey, thank you for seeing my solution :>>
About that green, I really did put that in there, it is a box-shadow when the hamburger menu gets focu.
About the line, oh yes I did not see that hahaha well the reason for not removing those is that, since they are a link right. The user won't be seeing those transition since they will be redirected in another supposed webpage or something like that, so removing those is not really necessary, if this were a real site where there are other pages.
For the last, keen eyes you got there hahahaha I'll implement that when I got the feeling but thank you really for that.
Thank you for reviewing^^
@thetechacks
Posted
@pikamart Oh the hamburger box-shadow looked as though it was a mistake :) Although I found another problem:
I think the mobile overlay div has a pointer-events: none value so that the hamburger menu could be closed, but it also causes few problems. I could select text and image even though the hamburger menu is open.
Hope it's helpful =)
@pikapikamart
Posted
@thetechacks Hey hahahaha you are really good on spotting those one and yes I did that for the button but like you said, the text can be selected and the button as well because the overlay is present, but it does not hide logically everything behind it.
Just to fix this, I will add again the pointer-events then just add z-index on the menu button.
Thank you really, though I won't implement this right away, I am teaching lots of my schoolmates about DSA in python and studying backend at the moment. But really, thank you so much^^
@thetechacks
Posted
@pikamart Glad I could help you
