Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Sunnyside landing page with react, typescript, and tailwind

#react#typescript#tailwind-css

@ronaldlamdev

Desktop design screenshot for the Sunnyside agency landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


This project was a 2nd attempt for me to try using TypeScript. Feedback is appreciated.

Community feedback

@caarlosdamian

Posted

Hello, excellent work I liked your solution, I would like to give you some feedback

  1. Enclose your main content in a <main></main> tag
  2. Instead of having your application src/assests/componentets , I would suggest using src/sections , since they are sections and not components example of is a testimonial card.
  3. Since you use typescript try to be more descriptive in the name of the properties and add the type when you are making a map.
  4. Instead of just using <divs> try using <section> so it's more accessible
  5. Use .ts instead of tsx when you are not rendering HTML
  6. Will be better to store yout data in src/utils/data.ts not tsx since your not rendering html

amazing work keep it up!!!

Marked as helpful

1

@ronaldlamdev

Posted

@caarlosdamian thank you !!! :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord