Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Sunnyside agency landing page

Desktop design screenshot for the Agency landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

P
Dave 5,245

@dwhenson

Posted

Hi Isaque803

Nice job here! Here's a few points you might like to consider:

  1. You could make the burger-menu element a button rather than a div. This will ensure that it can be opened by keyboard users.
  2. Perhaps have a look at the srcset attribute? This will means you won't need to always load two images to allow for wide/narrow screens, which is much better for performance.
  3. I think you need to put an accessible label on the svg icons at the bottom of the page? You could use aria-label (I think they should also be links?).

Otherwise nice job on this one!

Cheers Dave

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord