Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Sunnyside Landing Page

#accessibility#animation#contentful

@VanelleD

Desktop design screenshot for the Sunnyside agency landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

P
Ctrl+FJ 750

@FlorianJourde

Posted

Hey @VanelleD, good job with that one !

However, the main mistake for me in this challenge is the use of <img>, instead of setting simple <div> with background-image property in CSS.

With your solution, you need to fix images sizes, although they're more like "decoration", in the current case.

For example, in your .gallery section, you could just use background images for each div, and set CSS property with something similar to that :

.gallery .item {
    background-image: url('/image.jpg');
    background-size: cover;
    background-positon: center;
}

Maybe a small padding can be added, to set a kind of "minimal height/width".

With this option, your images are less "important" in term of HTML content, it will be easier to get a cleaner responsive, for example in your .about-img img, when screen size is ≈ 800 px, your .grid will display more naturally !

But your solution stays good ! Keep coding man !

Marked as helpful

0

@VanelleD

Posted

@FlorianJourde Thanks a lot for that idea. I really had struggles working with background images on this solution and didn't even think about that when I got to the gallery section but this advice you just gave could've made it better. I'll keep coding.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord