Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 4 years ago

sunnysideprojectsolution

Danny A. Mase•200
@admase
A solution to the Agency landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Any feedback is much appreciated. I still need more practice with responsive design and media queries for CSS3.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Grzegorz Sterczewski•680
    @gsterczewski
    Posted about 4 years ago

    Hello Danny 👋, my name is Grzegorz.

    Your work is ok, there is some work to do, but it's a good starting point.

    Here's my suggestions, I hope they will be useful to you

    • On desktop there is a not enough space for Stand out... heading, increasing width in this rule should help :

    section .container { width: 55% }

    • I would add some hover and focus states on anchors in nav to improve a11y

    • I would also add focus state on .brand-link so hovering and navigating with keyboard would have the same effect.

    • Consider using inline svg instead of img in social media links, so you can apply better hover and focus effects with adjustingfill property.

    This are the things you can fix pretty fast, later we can focus on improving layout and general responsiveness.

    Keep up the good work! 💪

    See you on the coding trail 😉

    Cheers!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub