Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Tailwind css, vanilla css and Javascript

CAMPSLOPY 140

@CAMPSLOPY

Desktop design screenshot for the Tip calculator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


i will like to hear honest feedbacks and what i can do to better myself as a frontend developer...

Community feedback

Account Deleted

The design looks ok, I just have some things to point regarding the functionality;

  • This is a calculator so the inputs should only be restricted to numbers, not letters and everything that comes with the keyboard.
  • I can enter negative numbers and it does the calculation anyways.
  • On the select tip % you have 10$ instead of 10%.
  • & I think the math is some kind of incorrect ;
  1. let's say the bill is $20 there's 4 people and I pick a tip of 25%, it gives me total/person of $3... that's way off. 4 * 3 = 12, there's no way that is going to cover a $20 bill.
  2. Haven't done this challenge, but I think you are supposed to take the bill which is 20$ in this case and divide it with the number of people, which is 4 in this case, so it'll be 20 / 4 = 5 each person is to pay $5 plus the tip of 25%, which is 20 * 0.25 = 5 and divide the 5 by 4 = 1.25 so each person is going to pay $6.25 when the tip is included.
  • And I may be wrong but I think that's how everything is supposed to work.

Marked as helpful

0

CAMPSLOPY 140

@CAMPSLOPY

Posted

@thulanigamtee Thank you so much for this awesome feedback. i have corrected the inputs and currently working on getting the calculations right. once i am done refactoring, i will push it live again. Thank you so much for this wonderful review

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord