Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Tarjeta de Productos responsive HTML/CSS

accessibility, bem
Ivan Bongiovanni•80
@ivan2214
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Tarjeta realizada a base html y css vainilla

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Agustin Sanchez•250
    @AgusSaMac
    Posted almost 3 years ago

    Hello Ivan congratulations on completing the challenge!

    I noted some things on your solution:

    • Be mindful of your reports. you have a couple of issues there.
    • You used two massive media queries, it would have been better if you wrote your code for mobile outside the query and just use the media query to expand to the other design.
    • On the same line, instead of one big media query, break it in several small chunks. It will be easier to mantain that way as your code grows larger.
    • You forgot give the proper font-family to the prices, and make smaller the original price.
    • The image is not centered on the desktop view. Just change your with in the card-sec-one from 40% to 50%. that should take care of that problem.
    • For the issue with the button on that same view, remove the margin-left and change your width=100% for min-width=80%

    Hope it helps,

    Keep it up and happy coding!

    Have a great day!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub