Testimonial section challenge, build with HTML,CSS,Sass

Community feedback

• 

  P

  Kamran Kiani•2,780

  @kaamiik

  Posted 5 months ago

  Hi. Some notes for your code:

  • In each .testimonial, The person name can be a h2 tag as a heding.

  ---

  • Also you have two blockquote. So you can structure like this:

    <blockquote>
      <p>Bold text</p>
      <p>Regular text</p>
    </blockquote> 
    

    And for your css you can add this too:

    blockquote > p.regular::before {
      content: "" ";
    }
    blockquote > p.regular::after {
      content: " "";
    }
    

    This CSS does not allow the " select when you wanna select the text with your mouse.

  ---

  • Profile images do not need alt text. You can set it to alt="". Avoid using words like image, picture, or photo in alt descriptions.

  ---

  • For your CSS, There is lots of files and honestly It's really hard for me to find the problems. I think If you are using vanilla CSS It's better to wrap all of your code in one file or two file.

  ---

  • Generally from your preview I can say you only need a max-width on your section tag. You do not need min-width. And for your grid, You only need four columns and two rows and there is no need to define the rows height in your code. It's not true. Take this very simple and do not over complicate the code for your self.

  02

  Marked as helpful
• 

  P

  Antônio Alves Cataldo•240

  @TonyzCataldo

  Posted 5 months ago

  Well, your design size is bigger than the request desktop design, outherwise your design is fine. keep coding.

  00