Michael Bishop• 1,070
@MikeBish13
Posted
Great job on this project!
A few things to point out:
- Each of the boxes overflows on the screen at mobile screen sizes. Have a look at the size of the content of each box, which is causing the grid to get larger to accommodate it.
- This problem could be because you've coded this desktop-first, whereas mobile-first quite often makes things a lot easier. For example at mobile screen sizes you're using a lot of
!importantrules on your grid layout, which isn't best practice. This should be a last resort only, so try tackling the problem from a different angle first. - Your footer is also inside the grid container and therefore becomes a grid item, which causes it to pop up in unusual places at certain screen sizes.
Hope this helps and keep up the good work!
0
