Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

responsive testimonials using flexbox

Ebsa Alemu 310

@burningorc

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


if you have any feedback or tips, please let me know

Community feedback

@MelvinAguilar

Posted

Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

HTML:

  • You must use a level-one heading (h1) even though this is not a full-page challenge. You can create an '<h1>' element within your 'main' element that will be hidden visually but visible and readable by screen readers. The class "sr-only" hides content visually and here are the styles to copy. e.g.: <h1 class="sr-only">Testimonials grid section</h1>
  • The alt attribute should not contain the words "image", "photo", "icon" or "picture", because the image tag already conveys that information.
  • In the image with the testimonial author you need to provide an alternative text to tell the user who is the author of the testimonial, its recommended to use the author's name as the alt attribute value. e.g. alt="Daniel Clifford"

If you want to learn more about the alt attribute, you can read this article.

  • To improve the semantics of your code you should use the <figure> and <blockquote> tags to wrap the testimonials, with this, you will be able to encapsulate the author and the citation of the testimonial.

Example:

<figure>
	<blockquote>
		<p>"Example of a testimonial"</p>
	</blockquote>
	<figcaption>
		<p>Example of the author</p>
	</figcaption>
</figure>

You can read more about the <figure> and <blockquote> tags with this two links:

  1. Quotations, Citations, and Blockquotes | CSS-Tricks
  2. Quotations | MDN Web docs

I hope you find it useful! 😄 Above all, the solution you submitted is great!

Happy coding! 🎄

Marked as helpful

1

@dazzlerabhi30800

Posted

for html issues just one level heading at a time like h1, h2 then h3. This will solve the Accessibility issue.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord