Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Grid Section

#accessibility
Anslyโ€ข 230

@Median21

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello! I have just finished the grid section. To be honest, it was hard. But there is something that is not quite right, when the right side becomes too long, the spaces on 2 of my grid sections becomes really big and ugly.

Hoping for tips and advices! :)

Community feedback

@MelvinAguilar

Posted

Hello again ๐Ÿ‘‹. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

HTML ๐Ÿ“„:

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

    If you want to learn more about the alt attribute, you can read this article. ๐Ÿ“˜.

CSS ๐ŸŽจ:

  • Use min-height: 100vh instead of height: 100vh. The height property will not work if the content of the page grows beyond the height of the viewport.

I hope you find it useful! ๐Ÿ˜„ Above all, the solution you submitted is great!

Happy coding!

Marked as helpful

1

Anslyโ€ข 230

@Median21

Posted

@MelvinAguilar Thank you very much and noted! ^_^

0
frontendcrackerโ€ข 100

@arrKhange1

Posted

Hello! It's almost great solution but there are a bit features to add:

  1. As for your problem, I would reorder elements on middle screens or even start a medium screen breakpoint a bit further
  2. Also, you got a container wrapping your grid. It's alright but if you had it with such params as:
width: 80%;
max-width: 1440px;

or the tricky one that does the same:

width: min(80%, 1440px);

it would be 2 times greater cause this way you would limit the content width to increase readability and also avoid too expanded content on wide monitors

Marked as helpful

1

Anslyโ€ข 230

@Median21

Posted

@arrKhange1 Thank you so much for the feedback and tips! Cheers! I will see to it in a little while :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord