@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- To improve the semantics of your component, you will want to wrap each individual testimonial component in a
figure
element, the individuals information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure>
<figcaption></figcaption>
<blockquote></blockquote>
</figure>
More Info:📚
- The profile images are not decorative. They should not be hidden. Their
alt tag
should state the following; “Headshot of -person’s full name-“
More Info:📚
- Never do this as it creates accessibility issues for users and it is outdated.
html {
font-size: 13px;
}
- For improved accessibility 📈 for your content, it is best practice to use
em
formedia-queries
. Using these unit gives users the ability to scale elements up and down, relative to a set value.
- Implement a Mobile First approach 📱 > 🖥
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
- Using CSS
grid
withgrid-template-areas
will make things way easier when building the layout and give you full control of it.
Here is how it looks like fully implemented: EXAMPLE
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎄🎁