Hi Seyide, As already said you need a little gap (margin/padding) at the very top and bottom of the screen so your cards aren't hitting edge of viewport.
Your grid looks great to me. If you're having trouble with it, try using grid areas next time, you'll probably find them a lot easier than trying to work out line numbers.
The only issues I see at the moment are all with html, which should be corrected:
-
Headings must go in order, and you should only have one h1 per page. This is important for assistive technology and for search engines. I would recommend making all the peoples names into h2s and not using heading tags at all for the quotes.
-
sections are meant to be used for large chunks of a document, a bit like chapters of a book. Again the reasons are for clearly understandable document structure. Using them incorrectly can have a negative effect for assistive tech users. This whole challenge could be wrapped in one section and given a title of 'testimonials', but there should be no sections within it. I would swap those for divs.
Hope thats helpful. Keep going with you're learning, you're doing really well with these challenges. Happy coding!
@SeyideHundeyin
Posted
@grace-snow thanks for your feedback. I will work on it!
