@zeerobit
Posted
Good work tackling and completing this challenge, here are a few pointers:
- as @steevencode mentioned the mobile design is not responsive, you should revise your media query
- no need to set a height on your ".testimonials-section" class
- revise your grid properties for the mobile design, you should not have to span columns to 4 for mobile size below 375px or even above since it can't fit this many column
- look up grid area it'd make it a lot easier for this challenge, check out this grid area tutorial
- the report indicates you have many issues in your html since you use section tag it's expecting each section to have a header . The correct semantics for this challenge would be
figure
to wrap the content for each card,figcaption
for the author section andblockquote
to wrap the paragraphs - Nothing wrong with a desktop first approach design but I usually recommend mobile first since it makes it a lot easier to design and it can save you a lot on css
Hope this helps, happy coding !!!
Marked as helpful
@Sonu-Dutta
Posted
@zeerobit thank you so much , I would definitely try to work on it 😊
@Sonu-Dutta
Posted
@zeerobit do we need to mention (figure , figcaption , blockquote) is it compulsory for the challenge?
@zeerobit
Posted
basically it's not about it being compulsory for this specific challenge, it's more about structuring html using proper semantics however these elements can be applied to any other challenge where they fit. Others have used the article element to wrap the card content for this challenge but i think the figure element is semantically more aligned with the context of this challenge