@correlucas
Posted
👾Hello @MelvinAguilar, congratulations on your new solution!
I’ve some suggestions for you:
1.You’re in the right track I can see that you’ve used the majority semantic tags possible for this challenge, the only block you’ve missed is the paragraph containing the quote text
you can improve the accessibility there using <blockquote>
to indicate to screen readers that the content inside that paragraph is a quote.
2.Its amazing that you’ve customized some interaction, you’ve to pay attention because when you add some hover effects
you've to think that for the mobile version there's an issue that the elements with hover get stuck
on the active state of the hover until you click on something else. Something you can do to avoid this problem on mobile, the stick hover, is to add a media query saying that you want hover effects only on devices that are not touch
. So you can use:
@media (hover: hover) {
{ADD HERE ALL THE CLASSES WITH HOVER EFFECTS TO DISABLE IT ON MOBILE}
}
✌️ I hope this helps you and happy coding!
Marked as helpful
@MelvinAguilar
Posted
@correlucas Thanks for taking your time to review my solution !.
I already use a media query for solving sticky hover states:
@media (hover: hover) {
.testimonial:hover {
box-shadow: ...
}
}
but maybe I have not put into practice some concept. Is this correct?
Thanks for the feedback!