Testimonials grid section using CSS Grid

Community feedback

• 

  Lucas 👾•104,160

  @correlucas

  Posted almost 3 years ago

  👾Hello Aram, congratulations for your new solution!

  You've a great solution here and I can see you paid a lots of attention for everything. The grid layout is fully responsive and the media query is working fine! The only thing to improve is the amount of div you've used here, note that many of these card elements can stand alone without a div to wrap it, the only block that really need a div is the block with the profile photo + job title, if you delete these unnecessary divs you'll reduce a big chunk of code since this divs will repeat around all the cards.

  ✌️ I hope this helps you and happy coding!

  02

  Marked as helpful
• 

  romila•3,550

  @romila2003

  Posted almost 3 years ago

  Hi Aram,

  Congratulations 🎉 for completing this challenge, the Testimonials looks great and is responsive. There are some issues regarding your HTML, and CSS I want to address:

  1. Since you are using the article tag, you need to include the heading tag which can vary from h2 to h6
  2. In desktop, I would strongly suggest you remove the padding property from the main tag since it is creating an overflow, where users would have to scroll down the page to see the bottom of the cards.
  3. To prevent the cards from being too wide, you can give the main tag a max-width of 1440px.

  Overall, great attempt and wish you the best for your future projects so keep coding 👍.

  03

  Marked as helpful