Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Testimonials grid section using Grid

Krish 660

@Alone-07

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedbacks are highly recommended

Community feedback

hardy 3,660

@hardy333

Posted

Hi, nice solution, congratulations on completing it.

Visually everything look super good and nice good job on that.

But there are some html accessibility issues as you can also see in the report above. There are few things you can do in order to fix those issues:

  • First of all you should always use <main> tag on your page, everything in this tag is considered as a main and primary content, in this case profile cards are main content. So for .container.grid element you can use main tag instead of div tag.
  • Other then main tag every page also need to have h1 tag, in this case there are no heading for which you will use h1 tag, but luckily there are special .sr-only tag which you can use, you can read more about sr-only tags from here, or even try to search about .sr-only class in google to find some good articles and read about it.
  • After using .sr-only h1 tag you should use h2 tags for heading for each profile-card component, not h3, so basically try not to jump on heading tags and try to use them in increasing/order without skipping any of them.

I think this fixes will resolve all html accessibility issues (hopefully).

Good luck and have a nice day.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord