Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Testimonials grid section with CSS Grid

Take 400

@ttakeyaya

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any suggestions would be appreciated!

Community feedback

yuenu 505

@yuenu

Posted

Hi, @Take

Nice work, it looks pretty good but there's a suggestion that would make the layout look better

  • On mobile, on className testimonials you can changing your grid-template-rows property to minmax , you don't defined the rows by yourself

And I would add .testimonial padding-bottom

.testimonials {
  grid-template-rows:  minmax(0, auto);
}

.testimonial {
  padding: 2.6rem 3.2rem 2.6rem 3.2rem;
}
0

Take 400

@ttakeyaya

Posted

@yuenu

Thank you for your comment. Your idea would improve the site. I'll tweak the points you mentioned.

0

@muhammadshajjar

Posted

Hi Take, Nice work on this one some suggestions would help you

  • Try to add max-width to your body or make a container class that wraps your all content, by adding it you can control your content from growing too much on larger viewports
  • To overcome your accessibility issue you would need to add some semantic markers to designate sections of the page as the header, navigation, main content, and footer e.g:
<main>
<section> 
</section>
</main>
<footer>
<div class="attribute"></div>
</footer>
  • Page should contain one 'h1'
  • Use bloclquotes for quotes instead of using p
0

Take 400

@ttakeyaya

Posted

@muhammadshajjar

Thank you for your suggestions! I'll fix those.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord