Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Testimonials-grid-section

accessibility, contentful
Anointed Kayode•420
@Coderio10
A solution to the Testimonials grid section challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Here is my solution to the challenge

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Account deletedPosted almost 3 years ago

    I have some recommendation to your code

    for best practices

    • always used fontSize: 16px; in the <p></p> since that is the standard size for paragraph if ever you did not used the 16px and some users went to your website it will be hard for them to navigate your website especially some users have a natural blurred vision.

    • the standard size for headings (h1 - h6) is 18px - 30px but it depends to the design template you're currently following but the size I mention. that is the standard size for headings.

    • for the name of testimonials never used h1 always used <span></span> when it comes to the name of a person the h1 - h6 are used only for the title of a paragraph example below

    <h1>Title of a paragraph</h1>
    <p>this is an a paragraph(story or messages)</p>
    
    • I noticed to your body {} CSS you used flexbox but you set the flex-direction to row instead column in the large display the <main> & <div class="attribution"> will become horizontal so much better used flex-direction: column
    body {
    ==> change this
        flex-direction: row;
    }
    
    • in the main {} CSS much better used max-width: 900px rather than 80% because if you used 80% in the max-width in the large display it will make your layout not good looking
    main {
    ==> change this
       max-width: 80%;
    }
    

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub