Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Testimonials-Grid-Section using CSS Grid and Flex Box

Aviel Hernandez•80
@AvielDez
A solution to the Testimonials grid section challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Can the CSS Grid method I used be dynamically implemented? The workflow I used works great for this challenge but I'm worried that this is a very static method for creating a Grid layout and cannot be used dynamically.

I placed a code snippit in the README.md file under the 'What I learned' section on github.

This was a great challenge for getting my hands dirty with CSS Grid. Grid is a great tool and I had to look at tutorials and do some external practice in order to wrap my head around using CSS grid. It's a very powerful tool and would recommend anyone to learn it as soon as possible.

I do feel like my HTML code could much cleaner and a lot tighter looking back. I could have implemented some CSS Custom Properties for colors and other general properties that span across the site as well.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Lucas 👾•104,160
    @correlucas
    Posted almost 3 years ago

    👾Hello Aviel, congratulations for your new solution!

    You did a good work here, nice grid layout.

    To Improve even more your solution you can replace the divs with semantic tags, for example the div holding all the content can replaced with <section> and the one that wraps which card with <article> and the one with the quote text with <blockquote>. Remember that div doesn't have any meaning are just block elements so for. Bigger blocks give ever semantic tags.

    Hope it helps, happy coding!

    👋 I hope this helps you and happy coding!

    Marked as helpful
  • Antoine C•1,240
    @mattari97
    Posted almost 3 years ago

    Hi Aviel. I think you have all the knowledge you need to make the page fully responsive, you just need to implement more mediaqueries.

    Right now you use only one for 420px.

    You could use a repeat(2, 1fr) for 420px, then repeat(3, 1fr) and finally repeat(4, 1fr) like on your current design.

    You also change your grid-template property each time and that's it 😃.

    Happy coding. Peace

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub