Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

That was first grid i have ever use that was really tricky to make it

accessibility
ata58011•220
@ata58011
A solution to the Single price grid component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Guys that was my first with grid if you guys have any suggestion or comments let me know. I am really curious about how can i make it better to project

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • Doston Nabotov•950
    @dostonnabotov
    Posted over 2 years ago

    Hi, there! That looks great! But, I found some problems, too.

    You don't specifically need to adjust the grid at 375px. If your phone is 400p, the UI doesn't look quite good. The preferred media query for most sites is 50em. So, you need to aim for that size. In the style-guide.md, it mentions how it should look at 375px.

    Wrapping all the text in one <p></p>, and giving each one <br> is considered a bad practice. Consider using <ul> and <li> to improve the accessibility of your site

    Furthermore, imagine this project grows in the future. As its name implies, it is a single-price-grid COMPONENT, which means that it will be used in other parts of the site as well. Thus, consider giving meaningful class names to your HTML elements. I recommend removing position: absolute from body in CSS. As the project grows, it will be much harder to maintain.

    Colors need to be adjusted according to the design.

    I hope it helps. Good luck!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub