Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

ThePLANETS HTML / SASS / JS

Yannis Haismannโ€ข 170

@YannisHaismann

Desktop design screenshot for the Planets fact site coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hey, i'm very proud of this one ! What can i improve in my code ?

Community feedback

P
ApplePieGiraffeโ€ข 30,545

@ApplePieGiraffe

Posted

Greetings, Yannis Haismann! ๐Ÿ‘‹

Good work on this challenge! ๐Ÿ‘ It's good to hear that you're proud of your work and I hope you had fun building your solution! ๐Ÿ˜€

I noticed that on some planet pages (such as Jupiter and Saturn), the magnifying glass that appears when clicking on the "Surface Geology" tab covers up some of the text in the tablet/mobile layout of the site. You might want to decrease the size of the images, then, to avoid this issue and also to make sure that none of the corners of the images are cutoff from not fitting within their container. ๐Ÿ˜‰

Keep coding (and happy coding, too)! ๐Ÿ˜

2

Yannis Haismannโ€ข 170

@YannisHaismann

Posted

Hey, first thanks for your support :)

I have tried to get the same issue but in my navigator, images are getting the perfect size. So maybe need a refresh to have the great size of the pic ?

Thanks for your feedback that's very helping :D

(Sorry for my english)

1
P
ApplePieGiraffeโ€ข 30,545

@ApplePieGiraffe

Posted

@YannisHaismann

Glad to help! ๐Ÿ˜€

Haha, I was typing something about the issue still being there, but a few page refreshes seemed to do the trick and the issue disappeared, for some reason. ๐Ÿ‘

BTW, don't worryโ€”your English is fine! ๐Ÿ˜„

3
joniโ€ข 365

@joni475

Posted

You forget to apply for the mobile version.

1

Yannis Haismannโ€ข 170

@YannisHaismann

Posted

No, I thought about it, maybe refresh page?

0
Yannis Haismannโ€ข 170

@YannisHaismann

Posted

Nevermine you're right i will repost it on my GitHub, thanks for your feedback !

0
P
Clรฉment Creusatโ€ข 1,675

@ccreusat

Posted

Nice one and it does the job! I would add a current/active link in the navigation according to the current planet :)

1

Yannis Haismannโ€ข 170

@YannisHaismann

Posted

Oh i see what you are meaning, thanks for feedback :)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord