Skip to content
Submitted about 4 years ago

ThePLANETS HTML / SASS / JS

Yannis Haismann•170
@YannisHaismann
A solution to the Planets fact site challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Hey, i'm very proud of this one ! What can i improve in my code ?

Code

Please log in to post a comment

Log in

Community feedback

  • ApplePieGiraffe•30,525
    @ApplePieGiraffe

    Greetings, Yannis Haismann! 👋

    Good work on this challenge! 👍 It's good to hear that you're proud of your work and I hope you had fun building your solution! 😀

    I noticed that on some planet pages (such as Jupiter and Saturn), the magnifying glass that appears when clicking on the "Surface Geology" tab covers up some of the text in the tablet/mobile layout of the site. You might want to decrease the size of the images, then, to avoid this issue and also to make sure that none of the corners of the images are cutoff from not fitting within their container. 😉

    Keep coding (and happy coding, too)! 😁

  • joni•365
    @joni475

    You forget to apply for the mobile version.

  • Account deleted

    Nice one and it does the job! I would add a current/active link in the navigation according to the current planet :)

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord