This challenge is perfect if you're just getting started.

Please log in to post a comment
Log in with GitHubCommunity feedback
- @PhoenixDev22
Hi Mohamed Khaled,
Great work! Congratulation on completing this challenge. I have some suggestions regarding your solution if you don't mind:
- About
<h1>
it is recommended not to have more than one h1 on the page . Multiple<h1>
tags make using screen readers more difficult, decreasing your site’s accessibility.
- You can add a
<h1>
withclass="sr-only"
(Hidden visually, but present for assistive tech).
- In this challenge , the images are much likely to be decorative. For any decorative images, each img tag should have empty
alt=""
as you did andaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images .
What would happen when the user click those learn more? In my opinion, clicking those "learn more" would likely trigger navigation not do an action so button elements would not be right. So you should use the <a>. For future use , it's a good habit of specifying the type of the button to avoid any unpredictable bugs.
Aside these, Great job on this one.Hopefully this feedback helps.
Marked as helpful - About
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord