Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

This challenge was completed with sass and sass variables

#sass/scss
MajidiyM 20

@MajidiyM

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello everyone✌🏻, if you check my code and give me suggestions to how improve it, I would be very appreciated, Thanks

Community feedback

Anosha Ahmed 9,340

@anoshaahmed

Posted

hey good job on this challenge! your report above shows a few issues though:

  • wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here
  • you should have at least one <h1> in your webpage

here is a list i made of accessibility issues & best practices

hope this helps :))

Marked as helpful

0
Naveen Gumaste 10,480

@NaveenGumaste

Posted

Hay ! Good Job you made it look nearly perfect to the preview

These below mentioned tricks will help you remove any Accessibility Issues

-> Add Main tag after body like it should be your container

-> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc

-> But use header tag only once in main heading element.

Keep up the good work!

Marked as helpful

0
Rio Cantre 9,710

@RioCantre

Posted

Hello there! Nice job with this one. Looking at your solution, I would suggest the following for you...

  • Inside the .component adjust the width into 355px and add margin-top: 5rem;
  • It's common to use div to wrap the content but it's better to use a specific tag for semantic like main .Wrap the .component with main tag

Overall you did well and Keep it going! Cheers!

Marked as helpful

0

MajidiyM 20

@MajidiyM

Posted

@RioCantre, thank you for your advice))

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord