This is simple CSS tricks not huge tools.

Community feedback

• 

  P

  Øystein Håberg•13,260

  @Islandstone89

  Posted 4 months ago

  Hey, good job!

  Here are some tips - I highly recommend applying these changes, as this is the best way to learn. Good luck :)

  HTML:

  • Every webpage needs a <main> element that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" content. Wrap the card in a <main>.

  • You don't need to wrap the image in a <div>.

  • The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website".

  • Headings should always be in order, so you never start with a <h3>. I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  CSS:

  • Make a habit of including a modern CSS Reset at the top of the stylesheet.

  • On the body, change height to min-height: 100svh— this way, the content will not be cut off if it grows beneath the viewport.

  • Descendant selectors like .card .info p increase specificity, making the styles harder to override. Instead, give elements a class, and use that as the selector.

  • max-width on the card should be in rem. Around 20rem works well.

  • Remove width: 100% on the card, it is not needed, as block elements take up the full width by default.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • On the image, add display: block, height: auto and change width to max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  • As the design doesn't change, there is no need for any media queries. When you do need them, they should be in rem or em, not px.

  01

  Marked as helpful