Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 5 months ago

time-tracker with vanilla js , HTML AND CSS

van-js
P
uzii•240
@Deuzi
A solution to the Time tracking dashboard challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

well , got to learn more about asynchronous way of writing just the articles way really help, what i will do different is make my code shorter , is kinda long for the few functions in the project

What specific areas of your project would you like help with?

the reviewer can help me check of way i could have made the code shorter and probably more understandable

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Abdulgafar-Riro•230
    @Abdulgafar-Riro
    Posted 2 months ago

    What’s Good:

    • Modular structure: Reports are grouped logically into dailyReport, weeklyReport, and monthlyReport functions.
    • Reusable fetch function: fetchData accepts multiple callbacks, making it flexible.
    • Clear DOM handling: Each function targets specific elements with informative error logs.

    What Needs Improvement:

    1. Redundant code:

      • The inner functions (work, play, etc.) are repeated across daily, weekly, and monthly reports with only timeframe differences. ➤Suggestion: Create one reusable function like updateActivity(dataArray, timeframe) and pass 'daily', 'weekly', or 'monthly' as needed.
    2. Typo in error messages:

      • Repeated "onew or more elements..." instead of "one or more elements..."
    3. Wrong error label:

      • Several times "play data not found" is logged even for other activities like study, exercise, etc. ➤ Suggestion: Log the correct activity title that wasn't found.
    4. Naming improvement:

      Function names like work, play, study, etc., are generic and repeated. Consider dynamic iteration over activities instead.

    Overall Suggestion:

    Refactor all dailyReport, weeklyReport, and monthlyReport into a single report function that loops through an array of activities and updates the DOM based on a given timeframe.

    Like this: const activities = ['Work', 'Play', 'Study', 'Exercise', 'Social', 'Self Care'];

    const updateReport = (data, timeframe) => { data.forEach(activity => { const { title, timeframes } = activity; const activityName = title.toLowerCase().replace(' ', '-'); const current = timeframes[timeframe].current; const previous = timeframes[timeframe].previous;

    const currentElement = document.querySelector(`.${activityName}-current`);
    const previousElement = document.querySelector(`.${activityName}-previous`);
    
    if (!currentElement || !previousElement) {
      console.error(`One or more elements for "${title}" not found`);
      return;
    }
    
    currentElement.innerHTML = `${current}hrs`;
    previousElement.innerHTML = `Last ${timeframe.charAt(0).toUpperCase() + timeframe.slice(1)} - ${previous}hrs`;
    

    }); };

    const fetchData = async (callback) => { try { const response = await fetch('data.json'); const data = await response.json(); callback(data); } catch (error) { console.error('Error fetching data:', error); } };

    // Handlers for each timeframe const dailyReport = () => fetchData(data => updateReport(data, 'daily')); const weeklyReport = () => fetchData(data => updateReport(data, 'weekly')); const monthlyReport = () => fetchData(data => updateReport(data, 'monthly'));

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub