Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 10 months ago

time-tracking-dashboard

P
KMS56135•160
@KMS56135
A solution to the Time tracking dashboard challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Eli Silk•920
    @elisilk
    Posted 10 months ago

    Hi 👋 @KMS56135,

    Congrats on a great solution. 👏 It looks almost exactly like the design.

    When you are ready to dive in further 🤿, I'd suggest a few things related to how the solution works at viewport widths between 1440px and 375px.

    First, when I tested your solution out, I noticed first that at 375px, your solution's height can go beyond the viewport height and so is off the screen (at least for my smaller screen 📺). I'd suggest in your dashboard class, changing the height: 100vh; attribute to min-height: 100vh; instead. That way the container fills the entire viewport, but is not prevented from scrolling.

    Second, testing out your solution at around a viewport width of 940px or so, it starts to get cramped and extends beyond the viewport (without scrolling). And then it continues to get more cramped until it switches over to one big column at 375px (as in the design). I can imagine different approaches to handle this kind of thing. Although maybe not the most flexible solution, adding a couple more breakpoints with media queries would be relatively simple to do. For example, you could move your dashboard container down to one column sooner (while keeping the stats-grid as is), so that the profile and time periods are on top but the stats grid stays at 3x3. Alternatively, you could move the stats-grid__inner down to two columns (from 3) earlier and keep the profile on the left for a little longer. Or do some combination of those two moves before you finally get down to one full column for the whole dashboard. To facilitate this, I'd suggest removing from the .dashboard class the attribute grid-template-rows: 518px; so that your dashboard is free to extend further in the vertical direction.

    Anyway, just something to consider if you are thinking about improving on this solution. 🤔

    Happy coding. 💻

    Eli

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub