Time tracking dashboard responsive made with flex-box and grid

Community feedback

• 

  Jordon Young•120

  @jordon-young

  Posted over 3 years ago

  Nice job on the desktop design!

  I like your transitions. I never thought to move any of the text. Proportions on the cards are great.

  My only comments on the desktop design are:

  • the grid gap should be the same for rows and columns
  • the footer is very difficult to read because of the low text color contrast

  I did my solution mobile first because I thought it would be too difficult to responsively minimize everything. Good luck as you finish! Don't be afraid of refactoring code or making a copy of your project and trying mobile first media queries (min-width).

  11

  Marked as helpful
• 

  Shashree Samuel•8,860

  @shashreesamuel

  Posted over 3 years ago

  Hey wanlucas, good job completing this challenge. Keep up the good work

  Your solution looks great however I think each of the 6 cards needs to be a bit wider to match the design.

  Secondly the text on your column card needs to be larger to match the image shown in the design

  In terms of your accessibility issues

  • Buttons must have discernible text, you can fix this my mentioning the aria-label attribute in the button tag

  • Images must have alternative text, simply mention the alt attribute in the image tag.

  In terms of your validation errors it will be resolved when the accessibility issues are fixed

  I hope this helps

  Cheers Happy coding 👍

  11

  Marked as helpful