Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 5 months ago

Tip calculator

P
rmmcfarlin•240
@rmmcfarlin
A solution to the Tip calculator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am happy to have gotten pretty close to the solution. I think my javascript could have been a lot cleaner and there were probably more efficient ways to handle the different functions, but as a beginner I think I did okay. I would probably plan out my javascript better and start with pseudocode instead of just going along and adding as I discovered I was missing functionality.

What challenges did you encounter, and how did you overcome them?

The main task was how to have the function run from interacting with either number input or any of the buttons, while also pulling the percentage from the corresponding button that had been activated. I ended up having an active / inactive class setup for the buttons, so the main function would pull from whichever button had been clicked last while still running the function on input when typing into either number input.

What specific areas of your project would you like help with?

Any general suggestions, especially on how to get cleaner and more efficient javascript. I know I have some repetition and inefficiencies there for sure.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Katia•290
    @ktzazz
    Posted 5 months ago

    wow you solved the challenge perfectly, congrats :D I was having trouble with the script, specially with the percentages but I did my research and found that using the method "forEach" could make the code more efficient. Good job!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub