Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 11 months ago

tip-calculator

Arcloan•770
@Arcloan
A solution to the Tip calculator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I managed to complete the task.

What challenges did you encounter, and how did you overcome them?

The buttons to select the tip required a little more of thought to fully function within the tip calculator.

What specific areas of your project would you like help with?

I dont't know how well I managed the buttons for selecting the tip and the total working of the tip calculator. Any suggestions are really appreacited :) Thank you

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • MaelkMark•150
    @MaelkMark
    Posted 11 months ago

    Nice solution, good job!

    For the tip amount buttons you can use input type radios instead of checkboxes, because then you don't have to uncheck them manually from js. Just replace checkboxes with <input type="radio" name="tip" value="5">. You must give them an identical name for the automatic unchecking to work. You can also give them a value (eg. the amount) and then you can get the tip amount with this line of code in js: document.querySelector(".button > input[type='radio']:checked").value. This line will return the given value of the checked radio button.

    Hope this helps (and please upvote)

    Marked as helpful
  • Teodor Jenkler•4,040
    @TedJenkler
    Posted 11 months ago

    Hi @Arcloan,

    Nice project! Here are a few suggestions for improvement:

    Input Validation: Currently, your inputs aren't validated. To ensure users can only input numbers, you can use an if statement to check if the value is a number. For example:

    if (!isNaN(Number(inputValue))) { // Proceed with showing value } else { // Invalid either let it block not a number/NaN or error message } This will prevent non-numeric characters from being entered and enhance the user experience.

    Keyboard Accessibility: For an extra challenge, you could make your calculator usable without the mouse. This can be achieved using DOM manipulation and handling keydown events. This will improve accessibility and provide a better user experience for those who rely on keyboards.

    Accessibility Improvements: Adding ARIA labels can significantly enhance accessibility for screen readers. Consider adding ARIA labels to your inputs and buttons. For example:

    <input type="text" aria-label="Enter number" /> <button aria-label="Calculate result">Calculate</button>

    This will help screen readers convey useful information to users.

    Hope these suggestions help!

    Best, Teodor

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub