Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

Tip Calculator App

bem
Abouelhouda Iliass•480
@ilyesab
A solution to the Tip calculator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm proud of the fact that within this project. I had to think about the user behaviour such as if the user focuses the custom tip percentage I have to uncheck any radio buttons as this indicates that the user wants to enter a custom tip percentage.

I also used inputs of type text rather than number because I couldn't hide or find a way to hide the spin buttons that comes with input of types number in a standard way across browsers. however I did attached keydown event handlers to text inputs to disallow the user from inputting letters. so they mimic inputs of type number.

What challenges did you encounter, and how did you overcome them?

The challenges that I had encountered was validating the data as it is being changed by the user and when we have all of the data that is required to make a calculation we update the display to show the results.

For that I used a form and inputs of type text and radio with the attributes required and pattern for validation. on the javascript side I have listened for change events on the inputs and used the Constraint Validation API to validate the inputs. whenever an input is changed we also check if we have all required information to start a calculation if there is we update the display.

What specific areas of your project would you like help with?

I tried to use BEM to structure my CSS and HTML Classes. It's always an aim for me to have structured and readable code.

I'd like to know if you found my code readable, understandable and follow best practices.

As always thank you for viewing my solution!

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

No feedback yet. Be the first to give feedback on Abouelhouda Iliass's solution.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.