Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

Tip Calculator App

Htein Linn•150
@hteinLinn210
A solution to the Tip calculator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


This is my first JUNIOR Challenge. I was away from the Javascript for a long time. So, I broke the Don't repeat yourself rule. And I also have to refactor codes. Feedbacks are warmly welcomed.

Happy Coding!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Darko•980
    @dtomicic
    Posted over 3 years ago

    I've glanced over the code and it looks nice to me, design as well. You managed to do some stuff that I found a bit challenging in this project so great job I might steal a few ideas :P

    However only "bug" I found if you can even call it that it's just like an annoying feature rather than a bug but you might look into it. When you put the amount of the bill and select the tip and if you haven't put in the amount of people you'll get an error saying that the people count cant be zero which is kind of not user friendly since the tip comes right after the bill amount many people using the calculator would first put in the bill amount then they would select the tip percentage and then at the end they would put in the people number so I would suggest letting the user set the bill amount and pick the tip percentage with just showing the textual warning above the input box that people input can't be zero, so get rid of the browser error message and calculate the amount only when people > 0 that should solve your problem.

    As for the next thing I've seen is that you reload the document on reset which is fine but I found the solution of just resetting all the values to blank or 0 far better and user friendly.

    Now all of the above advice is not something that is critical bugs or something like that I just like to think about the user experience since once you start developing websites for real users these kinds of things really matter, but nonetheless you did a great job considering you haven't written JS in a long time and the design looks great.

    Great job keep it up :D

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub