Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 9 months ago

tip-calculator-app-main

accessibility, bootstrap, sass/scss
Jose Sebastian•300
@wolf2lyon
A solution to the Tip calculator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • Wendy•2,150
    @wendyhamel
    Posted 9 months ago

    Hi there, looks like I got another of your solutions to review!

    Nice work on the layout.

    I noticed two differences with the design

    • the text color of a selected radio tip option should be the dark cyan
    • the padding of your caard is a bit wider thand the design.

    Apart fron those, I think your layout looks great.

    I had some trouble with reading the JS. It is a large file and some of the functions be broken up into smaller ones. And you still have some console.log()'s hanging around from testing.

    Last thing, I thing the calculation is off. I think you need to show the amount of tip per person and the total each person has to pay: this should be the part of the bill per person plus the amount of tip per person.

    I hope you can use my advise to improve your skills.

    Happy Coding!

  • P
    Paul•520
    @mayor-creator
    Posted 9 months ago

    Congrats on completing this challenge. It looks like select tips are logged to the console when you select a button.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub