@HYDROCODER
Posted
Hey there! Good attempt on this one. There are areas that you can improve so I would suggest the following if you don't mind :
-
Do put comments in your code, as it will be easy for others to help you, as well as for yourself, if you need to refer any part of your code.
-
Do use classes instead of ids. ID's are very specific selectors and they will mess up or increase the amount of code needed to write when compared with classes.
-
Try mobile first approach instead of desktop first approach. It will make writing CSS code a whole lot easier.
-
For correcting your accessibility issues, I would suggest you to look up on semantic html here. Instead of wrapping everything in a div, try using main or anything more semantic.
-
If two or more elements in your page use the same styles, use a class in your CSS code and use it in both the elements in html.
-
Never set a height on anything unless necessary for some very specific purposes.
-
Structure your html as per the desktop-version, style first as per the mobile version and then for the desktop version.
Hope this helps.
Marked as helpful