Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 10 months ago

Tip Calculator App

جهاد أحمد•280
@Gehad28
A solution to the Tip calculator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What specific areas of your project would you like help with?

Any feedback is welcomed :)

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Papi•280
    @Papi84
    Posted 10 months ago

    -->Overall Feedback<-- Great work on completing the challenge! 🎉 It’s clear that you’ve put in effort to implement JavaScript fundamentals effectively, and I can see that the project is functional and meets the basic requirements.

    -->What’s Working Well<--

    1. Functionality: Your solution handles the core functionality very well. The JavaScript logic seems solid, and the app performs the necessary operations correctly. The calculation of results (if this is a calculator or a similar interactive challenge) looks accurate and smooth.
    2. Design: The UI is clean and well-structured. I can tell you’ve paid attention to creating a simple and intuitive user interface, which is always a great user experience.
    3. Code Structure: Your JavaScript code is well-organized. You’ve broken down the logic in a way that’s easy to follow. I also noticed that your use of functions improves the reusability and readability of the code.

    -->Suggestions for Improvement<--

    1. Error Handling: Consider adding error handling or validation for edge cases. For example, what happens if a user inputs a value that doesn’t make sense (e.g., negative numbers or letters)? Adding simple validation could improve the user experience by preventing unexpected results.
    2. Accessibility: Improving accessibility can make your project more inclusive. Adding more descriptive alt text to images, using semantic HTML, and ensuring the app is keyboard-navigable would help make the project more robust for different users.
    3. CSS Improvements: You could also improve responsiveness slightly to ensure that your design scales perfectly across all screen sizes. Adding more media queries or using responsive units like rem or percentages can help.

    -->Enhancements<--

    1. Additional Features: To take your project to the next level, you could consider adding some interactive features like animations or more detailed visual feedback for user actions. For example, dynamically highlighting input fields, or displaying a real-time preview of the calculations, can add polish to the experience.

    2. Code Refactoring: In your JavaScript, you might want to refactor repetitive code into reusable functions. This will make your code more maintainable and cleaner, especially for larger projects.

    -->Conclusion<-- Overall, you’ve done an impressive job with this project! The core functionality works well, and your code is easy to follow. A few adjustments in accessibility, responsiveness, and error handling could elevate the user experience even more. Keep up the great work!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub