tip calculator app Sass vanilla JS

Community feedback

• 

  Eray•1,410

  @ErayBarslan

  Posted almost 3 years ago

  Hey there, functionalities works as supposed to, design looks good and is responsive. Great work! My suggestions:

  • Unless you really need to, it's better to not give height to container elements. Always try to let the child elements define the height of parent by margin, padding etc. For screens more than 960px, max-width of .container is set to 55vh. When the height of screen gets smaller, this causes elements to overflow.
  • Because of defining container width by vw on several media queries, by the time screen gets bigger, size of container changes back and forth disproportionately. It would be better to keep vw for one query and then set a max-width with px or rem once it reaches the desired design.
  • For calculation output you can use .toFixed(x) method to prevent high number of decimals overflowing. Amount of shown decimals will be limited whatever you give to x value.

  Other than these amazing work again and happy coding :)

  00

  Marked as helpful
• 

  szam•800

  @k-stopczynska

  Posted almost 3 years ago

  Hi,

  Yeah, forgot to fix decimals and also about the error message.

  Thanks for review, really appreciate it.

  Happy coding!

  00