Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 3 years ago

Tip Calculator app using HTML, CSS and Vanilla JS.

Renan Tiscoski•1,240
@DonUggioni
A solution to the Tip calculator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hello,

This challenge was fun, even though it is not working as I intended.

I wanted to display the values once the user fills in the number of people, but couldn't figure out a way to do it, so, the last element to be choosen is the tip, so after the Bill value and the number of people, the user has to select the tip value in order to display the values.

When the user selects the custom tip, they have to click the field once again in order to get the results.

Also implemented some conditions to check if the numbers are positive and not letters.

Overall I believe there's room to improve my code so any comments are welcome.

Happy coding 🤓

Edit:

Refatored the JS code, now the app works 100% as I intented.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Ahmed El_Bald•1,020
    @Ahmed-Elbald
    Posted about 3 years ago

    Hey Renan,

    So concerning your questions, I don't really know the logic you used but here's my suggestion:

    • Basically you should have your variables like totalAmount, tipPercent (or however you name them) as global variables and set them to null.
    • You have three inputs in the page (the bill, number of people and custom tip). You can add an eventListener to all of them (onkeyup OR oninput both will work).
    • So when the user types any thing, you can detect what input is being used and then set new values to your global variables
    • Then, you can trigger a function to display the final values but this function shouldn't work unless your global values actually have values other than null

    I don't know if I managed to convey my point but the whole thing is... You don't have to click anything to display the final values. The function that will display them should get triggered every time the user types anything

    If you still don't get it, you can see my solution here

    You have some issues with accessibility. I don't mind helping you solve them. I hope my feedback was beneficial. Thank You

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub