Skip to content
Submitted over 3 years ago

Tip calculator app using Html Sass and Javascript

Ronel Florida•450
@Ronel028
A solution to the Tip calculator app challenge
Preview (opens in new tab)Code (opens in new tab)
Code

Please log in to post a comment

Log in

Community feedback

  • Anosha Ahmed•9,300
    @anoshaahmed

    To avoid accessibility issues in the future:

    • wrap everything in your body in <main> OR give role="" to the direct children of your <body> ... Click here to read more
    • have at least one <h1> in your code

    Good job! :)

    Marked as helpful
  • Siege•520
    @idesmar

    Hi Ronel, Congratiolations in completing this project! The site looks great on mobile and desktop view. Your code looks clean and understandable.

    Just a few feedback on HTML that wasn't covered by the report generated by FEM regarding <small>. Although this is allowed, it goes against the principle of separation of concern. So even if it's allowed, taking SOC into consideration is always a good thing to bear in mind. Click here to read more about the <small> tag.

    Regarding landmarks, you may want to use <header> to contain the logo and <main> for the rest. That should fix some of the landmark concerns on your page.

    For JS, perhaps, create a return where if output is NaN, it won't change textContent or something similar.

    Great work and Happy coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord