Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

Tip calculator by HTML SASS and JS

sass/scss
Mariem Ehab•335
@MaryEhb
A solution to the Tip calculator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


was the design tricky or it is just me ? I felt that it looked easy before I started coding it but it took a lot of time to finish I also feel that the code is really messy and complex than necessary but I can't fix it so I really need all the advice and feedback that can come to mind on everything

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Allan Kirui•210
    @AllanKirui
    Posted over 3 years ago

    Hello Ehab, it's not just you. The design was actually tricky 😅 So you should be proud of yourself for putting in the time to get the project done. Not many people have been able to finish the challenge.

    Have a look at this repository I made about how I personally approach coding designs. I use this approach with every project and it has saved me a lot of time and headaches in figuring out where or how to start tackling a challenge. You might get some useful insights from it: https://github.com/AllanKirui/designing-and-coding-layouts

    As for your code, maybe for the HTML you code get some more practice with forms especially with how to use the <label> tag with the 'for' attribute.

    If you'd want to chat, find me in Frontend Mentor's Slack Community @Nalla Will Jr

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub