Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 2 months ago

Tip calculator

RickyPWebDev•200
@RickyPWebDev
A solution to the Tip calculator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What challenges did you encounter, and how did you overcome them?

I had a challenge around the scoping of one of variables

let tipOutput = document.getElementById("tip-output"); let totalOutput = document.getElementById("total-output");

These variables where original local scope within my function: collectUserInput();

I tried to access these variables in my resetOutPut() function which lies outside of the scope of that other function. I first tried correcting this problem through calling these variables as arguments in the function, but I found that I had to just make these variables global.

For some reason my resetOutput function does indeed clear the output but it requires 2 clicks? ive tried doing a little debugging, but it's ones of them weird bugs where the interpreter basically ignores that there is an issue; I.E no syntax error ect..

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • alinakanivecka•370
    @alinakanivecka
    Posted 2 months ago

    You need to pay attention to styles. And you should do buttons as <buttons>, not <inputs>, because user can write anything there. As for your issue with resetOutPut(). The problem is that your function adds an event listener to button but it is being called only when user clicks it, so the click event handler will only be called on next click and each click will add an additional listener. So if you click 100 time, on 101st time event listener function will be called 100 times. You should either:

    1. remove onclick from html and call your resetOutPut() in js once or
    2. rewrite your resetOutPut() so it does not add an event listener but only resets values. So when button is clicked it resetOutPut will be called since used in onclick and it will clear your elements content

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub