Skip to content
Submitted about 1 year ago

Tip calculator

Graeme Byrne•520
@grmbyrn
A solution to the Tip calculator app challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What are you most proud of, and what would you do differently next time?

Getting the JS to all work together.

What challenges did you encounter, and how did you overcome them?

I found the layout of the project a little strange. Having an error message appear when there isn't a button to press to make the calculation was a little odd for me. I left it out.

What specific areas of your project would you like help with?

I would like any advice on how to get the bill, tip percentage, and number of people info and how best to calculate the tip amount and total as I think I could improve that.

Code

Please log in to post a comment

Log in

Community feedback

  • Branka R•290
    @brainka

    Hey! Nice work on project.

    From my observations, your calculations appear to correctly calcualte the tips, so I don't believe you need to change anything there.

    Just a few items of note:

    As a user going through your form, I notice that the tip amount and tip total only evaluate when you click on the select tip % button or when you enter a custom amount.

    Which means, when the user enters in the Bill, selects the tip % and enters the number of people... nothing happens....the user has to then go back to click on the select tip % in order to have the total evaluate.

    I would consider adding an additional event listeners to your other input fields (just like you did with the custom tip field), so when the user types or updates their values, the form will also be updating the totals.

    Hope that helps a bit!

    Happy coding :)

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord