tip-calculator

Community feedback

• 

  Yacine Kahlerras•820

  @yacineKahlerras

  Posted almost 3 years ago

  Hi @roadblock37 just read your code and its excellent ! love that you commented it pretty well and I didn't have a hard time understanding it at all, well done. I just have a few suggestions that might be helpful

  • in the custom tip event listener you should get the latest radioChecked from the dom

  const radioChecked = document.querySelector("input[name='option']:checked")
  // uncheck tip percentage if there is a custom amount input
  if (radioChecked){
          radioChecked.checked = false;
  }
  

  otherwise it will only get the radiochecked from when the page was first loaded (which is 5%).

  • in the computeTip the math side of it should be :

  perPersonTip = ( bill * (tip/100) ) / numPeople
  totalAmountPerPerson = (bill / numPeople) + perPersonTip 
  

  otherwise good job on the challenge and happy coding !

  00

  Marked as helpful