Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 4 years ago

To do App

Val•95
@el-shredders
A solution to the Todo app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi all! Here is my take on the todo app challenge. done in html/css and vanilla javascript. It's still not 100% finished:

  • i haven't implemented the drag and drop features (its a bit out of my league for now maybe)
  • I still have to do the "Clear Completed" feature.

I'd still have reviews or advices from you guys on a few points.

i m not sure I used the best Html structures to do this, for structure and semantics,

it was my first time adding a theme switcher, i used a single data attribute in my body to get it done, if you have any suggestions to improve it

I did the Js part in procedural programming, so it's a bit hard to keep everything clean (i tried my best and added lots of comments) So if you guys have any advice for me to keep my code cleaner or anything, i'll happily take it.

And i was wondering if it was a good practice to kill the event listeners on a todo Element removal, if so what would be the best practice to do it?

Thanks in advance Val

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Val•95
    @el-shredders
    Posted over 4 years ago

    And the project is in the master branch (i accidently gave the link to the main branch).

  • Val•95
    @el-shredders
    Posted over 4 years ago

    I can't seem to edit my solution, so litte update in the comments. I finished to implement the Clear completed feature, added the responsive part. And added the default list elements on first load via JS

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub