Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

Todo app

react
Ammar Jalabi•270
@AmmarCode
A solution to the Todo app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi, I just finished my to-do app with React.js. I welcome criticism.

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • J.D. Browne•870
    @PeshwariNaan
    Posted over 2 years ago

    Hello Ammar - great job on completing the challenge. The functionality works well and the responsiveness is very good.

    Here are a couple tips that might help with your code:

    • Try to make everything modular when using React. The thing that makes React good is that it only renders the things that change to the real DOM. If you don't break up your code into different components, you will have lots of unnecessary re-renders for components that don't need to change. For example, you could split up the todolist component and make the todo items a separate component and then map them into the list. Also take the taskbar that is coded in the todolist component and make it a separate component. This way you only re-render what needs to change and your code will be much more efficient. You can take a look at my solution if it helps here. You can also see how I implemented the drag and drop using beautiful dnd if you would like to add that to your project.

    • For the input component, don't enable the check-mark in the circle. There is no reason to have a check on the input. I made mine so it will clear the search field when clicked instead.

    I hope you find these tips helpful - Happy coding

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub