
Solution retrospective
Feedback would be welcomed
Please log in to post a comment
Log in with GitHubCommunity feedback
- @gsterczewski
Hello Leonel,
I like your work on this 👍. Your js is well organized and easy to understand, which I struggle with.
I have a few suggestions :
- Consider adding label to
.input__todo
, since it would help with accessibility. -I think your could tweak box-shadow on.todos
since in blends with the background on light mode too much. -It would be nice to add some better support for keyboard users, e.g. set focus on todo and mark it or delete it with key press. Right now I can only set focus on .input__todo - How about setting
cursor:poiner
on.header__theme-switcher
to indicate that this element is interactive?
Anyway, thats my suggestions for little improvements, overall you did great job 👏.
Have a good day. Cheers!
- Consider adding label to
- @abhik-b
Hi Leonel ,
You have done a great job on this challenge , I really liked the class based approach you took💯.
Great job 👌👌
Keep it up 💯
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord