Tracking Dashboard with HTML, CSS and JavaScript

Please log in to post a comment
Log in with GitHubCommunity feedback
- @dylan-dot-c
Good job on this challenge, but there are a few places you can improve.
- The flashing when trying to load data for the timeframe is annoying, so you don't need to fetch the data everytime, or show the loading everytime, since the data is static. You could also make the data.json a js file and import it.
- The last timeframe labels are wrong. It should be: Yesterday for daily, last week for weekly and last month for monthly.
- also its not accessible as the buttons aren/t focusable, you can make them buttons or anchor tags so they can be reached with keyboard tabbing.
- You also need to fix the responsive design, as its not perfect on mobile screens that are larger as the top is left aligned and not center.
- you can also add an extra check where if they click the active timeframe it doesn't get the data again, as its already showing
You did good overall, just a few things to improve upon. For extra challenge you can add URL statemanagement
I also did this with vanilla js so check out my solution to see how I implemented everything I mentioned
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord