Tracking time dashboard with API and Promises

Community feedback

• 

  

  Gwenaël Magnenat•1,540

  @gmagnenat

  Posted 20 days ago

  Hi congrats for giving this challenge a try. I'm afraid it needs a bit of work to make an accessible and production ready solution. This component uses a common pattern called the "tabs pattern" you can read more about it here. https://www.w3.org/WAI/ARIA/apg/patterns/tabs/

  There are quite some semantic roles and properties to add to make this right.

  Also, you shouldn't hide the outline and focus indicator on interactive elements such as links or button. You can style these if you want but they are essential to show where the focus is for users who are not clicking around with a mouse.

  Try to use your solution with your keyboard only, you will see what I mean. Try to access the different stats card without using your mouse.

  Can you spot the problem?

  10

  Marked as helpful
• 

  P

  Lo-Deck•3,700

  @Lo-Deck

  Posted 27 days ago

  Hi well done for this challenge,

  You need to use more semantic tag to improve your HTML, it's better for screen-reader and SEO.

  Use a div when there is no other choices, you can use section, article... like <section class="card play__card"> and <main class="dashboard">,

  11

  Marked as helpful